On Mon, 2007-08-13 at 17:59 -0500, James Bennett wrote: > On 8/13/07, Adrian Holovaty <[EMAIL PROTECTED]> wrote: > > Proposal #1 seems simpler, but this is not a strong opinion. :-) > > The only thing that's keeping me from posting a patch for this right > now with option 1 is a lingering doubt about whether one of the > queries would be preferable; in the spirit of Simon's question about > SELECT 1 on the newer backends, could some of our gurus weigh in on > whether there's any appreciable difference on Oracle or MS-SQL between > the two options?
My preference would be for option #1, since it feels neater (and the "subtract one second approach" just narrows the gap; doesn't remove it entirely). Surprisingly, I think you might find SQLite is your main problem here. We've had some bugs in the past because SQLite doesn't seem to cast 'YYYY-MM-DD' to 'YYYY-MM-DD 00:00:00' when it needs a datetime, or something similar to that. There's one case I dimly remember where we had to explictly add in or remove "00:00:00" for one check, but I can't find it now (I would have expected it to be in db/models/fields/__init__.py or db/backends/util.py). So test carefully on SQLite, particularly on something that is a release from, say, 8 months ago or so, since people won't have the absolutely latest release all the time. Regards, Malcolm -- Quantum mechanics: the dreams stuff is made of. http://www.pointy-stick.com/blog/ --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
