On 9/8/07, Jacob Kaplan-Moss <[EMAIL PROTECTED]> wrote: > > On 9/8/07, Joseph Kocherhans <[EMAIL PROTECTED]> wrote: > > Any serious opposition? > > Not at all -- this sounds perfectly sensible, and a good improvement.
Committed in [6080]. I don't think anything in there makes Russell's suggestions about fieldsets going in newforms any harder than they were. In fact, it would probably be easier to do now. Also, this changeset makes either fields or fieldsets restrict the fields on the actual newforms Form objects (by passing the flattened field names to form_for_model.) That way there aren't any fields that exist in python, but aren't displayed. It's possible that you can shoot yourself in the foot this way by not providing required fields to the db layer, but those bugs are a lot easier to track down than the ones where you get errors from the form, that aren't displayed on the page anywhere. (I'm sure we've all done that one almost every singe time we're using fieldsets and add a required field to the model ;) Joseph --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
