"I've written before on mailing lists that only about two out of every
five submitted patches I review go in unchanged on a good day and that
seems to match other maintainers' experiences, too"
-- 
http://www.pointy-stick.com/blog/2007/11/02/development-experiences-version-control/

This obviously slows down patch inclusion.  I was wondering if it
really takes a committer to polish the patch well enough for
inclusion?  We all know code review is generally worthwhile, and I
regularly make improvements to my quite-good coworkers' commits on our
internal tree.

I think Mozilla has this sort of thing in its "review, super-review"
process.  It seems worth experimenting to see whether it just takes a
second set of eyes, not necessarily committer's eyes.

If we could get the ratio up to 4 of 5, would that make a significant
difference in inclusion speed, or is it still the committer's time to
review that slows it down?  How many hours in a week (month?) do
committers spend on patch polishing?

  -Jeremy

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to