On Nov 14, 2007 10:04 AM, Forest Bond <[EMAIL PROTECTED]> wrote: > I'm not entirely convinced the overhead is all that terrible, especially given > that: > > * Database writes are less frequent than reads. > * Anybody overriding save is probably adding more overhead than this anyway. > > Maybe we could only engage this slight trickery if we detect that save has > been > overridden by a sub-class of Model? Then, if save hasn't been touched, there > is > no additional overhead.
It still seems unnecessary to engage in this activity in core itself. Like anything else, *if* someone actually finds the need for this (as Jeremy has), they're free to do it themselves. I see no reason to make assumptions about what users will be doing with their overridden save() methods. I expect most cases won't even care when post_save is called, and still more will actively expect it to be sent when they call super(MyModel, self).save(), and I think it's best not to break that. So, it's probably the minority of cases where this is necessary anyway, and people in those situations will know they need it. As long as we make it available and document it, it should suffice, I would think. -Gul --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
