On 12/12/07, Nick Lane <[EMAIL PROTECTED]> wrote: > > I had a quick look at writing some tests for #6191[1], and have a few > queries. > > Should I be testing the admin delete view to make sure the response > contains the expected items, or should I just test the "private" > _get_deleted_objects() method, to check the items are returned in that > list?
Just testing _get_deleted_objects() is fine by me if you can. I think the AdminSite object might be intertwined with things in the newforms-admin branch, so there may still be a bunch of setup. > P.S. I used Mercurial queues to do the patch, but not sure how to spit > out a diff in a way which is useful in trac. Trac will store the actual text of the patch, even if it doesn't display it correctly. I'm just going to download it and apply it anyhow, so seeing the pretty web interface doesn't matter much to me. :) Joseph --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
