On Feb 5, 2008 2:12 AM, Malcolm Tredinnick <[EMAIL PROTECTED]> wrote: > > It's a little unclear from your post whether you're reporting another > bug, saying what you think should happen or describing what does happen. > Are you demonstrating actual output or preferred output?
Yes, I see now my message doesn't clearly state what kind of feedback I was after. I wanted to get more experienced eyes to see if the patches attached to #6409 (actual fix is by simonb, I just added regression tests) were right or they needed to use another strategy. Problem is that it initially was a comment for the ticket and then I tried to convert it on an email to -dev. Add to it it was 2AM here and my habitual akwadness with English and you get a message like that. > I don't understand your "commas" note above Forget it, it was about typos I made on a previous comment to the ticket. > When that change goes in, the code for getting the language preference > can be simplified dramatically, since the security fix was quite ugly in > order to attempt to preserve backwards-compatibility (and unfortunately, > I chose to test it on es-ar ,rather than zh-cn, so I broken the Chinese > versions). Somehow, I suspected the es_AR translation tuple, by appearing first on the LANGUAGES list and having that "es_AR instead of es-ar" error had some responsability on this. Sorry for that. > For you personally, it introduces a slight > change for es-ar (from es_AR), which will affect people writing their > own LANGUAGES list, but that's probably a reasonable price to pay for > simplicity and consistency in the code and config files. > I agree and was thinking about adding a blurb to the BackwardsIncompaibleChanges wiki page for the (few?) people using es_AR, when #6446 gets fixed, if necessary. Regards, -- Ramiro Morales --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
