I had mentioned this a while back, in passing, but I'd like to bring it up again now that the filestorage patch is getting close to making it into trunk.
In particular, I thought I had remembered some discussion a while back about how expensive different test packages were, since each package requires a setup/teardown of the database. Normally this is an acceptable inconvenience, but it becomes a burdern for tests that don't actually use the database. This ties in with file storage because there are actually two distinctly separate things to test: model-related file stuffs and those features that don't care about models. I already have a number of tests for the model-related work: FileField upload_to, etc. That's all well and good, and it essentially tests the underlying file storage code by virtue of relying on it. However, I'm noticing that there are a number of features that exist solely in the storage aspect, without any relation to FileField. I'd rather test these in a separate test package, so it's obvious where the line is drawn. For instance, it doesn't make sense for modeltests to include a test of whether a given file path is actually beneath the storage system's base location. I'd rather have a separate package for those types of things. So, my question is this: how expensive is it, really, to setup and teardown the database and whatnot, with two separate packages? Is it enough to merit rolling all these tests into one package, or would it be worth it to maintain the separation of concerns? If it's best to have two separate packages, I'll make that change and upload a new patch to be looked over while we wait on the streaming upload stuff to finish up. -Gul --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
