On Sat, May 17, 2008 at 2:27 AM, Sebastian Noack <[EMAIL PROTECTED]> wrote: > I have released a new patch. See > http://code.djangoproject.com/attachment/ticket/7210/0001-Added-expression-support-for-QuerySet.update.3.patch. > > I still have to write tests and documentation, but I would like to hear > from Russel or the other maintainers, what they think about the code.
What do I think? The code doesn't look fundamentally bad, but I'm not going to take a serious look until there are some test cases. Consider this from my point of view. I need to validate that your code works as advertised. As your patch currently stands, I need to write my own test cases, including coming up with some models, some test data, and thinking about the edge cases that need to be checked. This takes time - time that could be spent looking at someone else's code, merging someone else's patch. Given that my time is limited, and there are multiple demands on my time, it makes sense for me to concentrate on those patches that make my life easy, and enable me to process as many tickets as my limited time allows. Like I said last time, test cases are how you prove you are serious. It's how you prove to me that you've done more than a trivial analysis of the problem. It's how you prove to me that you've considered the edge cases. And for your own sanity, it's how you prove to yourself than when you make one of those "minor, this couldn't possibly affect anything" changes, that it actually doesn't change anything. Yours, Russ Magee %-) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
