I just read over
http://code.djangoproject.com/ticket/3335
and want to confirm a suspension that I would like to add to that 'thread' in 
an 
attempt to keep it closed:

404 processing happens, then the flat-pages code is given a chance to override 
it.  This means that if the 404 processing fails, you get a stack dump where it 
failed.  The fact that what is failing 'might' not be needed (in the case of a 
waiting flat-page entry) does not effect the fact that the code still crashed.

I tend to agree that the DEBUG setting should not effect the flat-pages system 
the way it does, but I am comfortable with the resolution that it is an 
unfortunate side effect of the way flat-pages is implemented, and re-coding it 
to address the DEBUG issue isn't worth the effort.

There was a note about improved docs, but the trac issue was also closed, which 
makes me think the doc patch isn't going to happen.  I think 
http://www.djangoproject.com/documentation/flatpages/ needs:

"Make sure you have a 404.template page before you set DEBUG=False or you will 
get a stack dump even when there is a valid flat-page waiting."

This will address the "violates the principle of least surprise" and I have to 
admit, I too was surprised.

Carl K


--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to [EMAIL PROTECTED]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to