On Thu, Jul 3, 2008 at 8:27 PM, Russell Keith-Magee <[EMAIL PROTECTED]> wrote: > > On Fri, Jul 4, 2008 at 4:57 AM, Leo Soto M. <[EMAIL PROTECTED]> wrote: >> >> Hi all!, >> >> I've posted a patch[1] with a small refactor to some Field's >> get_db_prep_* methods. Basically, for non-basic field types, the >> database-prepared values is not computed by the Fields anymore, but > > Hi Leo, > > I've had a quick look at this patch. On the surface, it looks like a > good idea and a pretty good implementation, but I'll need to spend a > bit more time with it before I pass final judgement.
Sure, and thanks for setting a few time aside to do this first review! >> This patch is part of my work of running Django on Jython, and in >> general helps anybody who maintains an external django database >> backend. > > Completely aside from that, it may actually fix a few other problems > we've been having - for example, MySQL's habit of returning 1/0 from > boolean fields. I'm not sure about it. The patch improves the Python -> DB conversion, not the other way around. -- Leo Soto M. http://blog.leosoto.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
