On Mon, Jul 7, 2008 at 10:00 AM, Russell Keith-Magee <[EMAIL PROTECTED]> wrote:
> > Hi all, > > I've been looking at #6017 and #5943 of late. These two tickets have > been around for a while; one of the biggest reasons that they have > taken so long to address is that they cover an area of Django where > the testing isn't automated - the behaviour of django-admin.py and > manage.py. As a result, it's very hard to validate that when a change > is made that the change doesn't break some obscure use case for these > scripts. > > I've just uploaded a patch to #6017 that will hopefully address this > issue. The patch 'django-admin-tests.diff' contains a prototype test > framework for django-admin and manage.py scripts. It works by spawning > a child process using popen3, setting up the test environment using a > bash script and checking the contents of stdout an stderr as a test > condition. > > At this point, I'd appreciate some feedback. In particular, I need a > sanity check that the test scripts run on other unix-based systems. > I've run this test under OS X Leopard, and all the tests pass for me. > However, I don't have particularly ready access to a Linux etc > development box, so I can't confirm if there is any platform-specific > wierdness that I need to account for. > I get 17 failures running on Ubuntu (gutsy), but maybe I'm missing something else needed for the tests to run properly? I just added the django-admin-tests.diff to a pristine trunk checkout. I had to create an __init__.py file in the admin-scripts directory and set the execute bit on the .sh files. Here's the output: http://dpaste.com/61132/ Of 77 tests that run only 17 report failures so some things are working but it isn't immediately obvious to me what's going wrong with the rest. I would also appreciate it if anyone could confirm that the same test > approach will work for Windows. I have almost no access to Windows > boxes for development purposes, so I'm completely in the dark here. > However, as far as I am aware, popen3 should be available and operate > in much the same fashion as it does under Unix, so the only > modifications required should be writing a .BAT script to set up the > environment and modifying the utility routine that starts the script. > If I'm wrong, any suggestions for an alternate approach are welcome. > > Simon's idea of eliminating the bash scripts entirely sounds good to me, assuming it can be done. I do have Windows boxes and could probably cobble up some .bat files if really necessary, though I haven't done .bat programming since DOS days (and not much then). So, if it's not possible to eliminate the platform-dependent scripts I can try to replicate what you've got in the shell scripts on Windows, but I'd prefer the approach of eliminating them. In any event I can do testing on Windows. Karen --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
