On Wed, Aug 20, 2008 at 11:42 AM, Justin Fagnani <[EMAIL PROTECTED]> wrote: > > On Wed, Aug 20, 2008 at 8:39 AM, Brian Rosner <[EMAIL PROTECTED]> wrote: >> I am slightly unclear on what is allowed to >> be broken in this phase of Django development. I suspect it is okay >> since those methods are not explicitly documented and a quick note on >> the wiki would be decent. Someone please correct me if I am wrong, but >> will make this item post-1.0. > > I could rewrite the patch to preserve those methods, but it'd be a lot > less elegant. I could see the argument that save_existing_objects(), > and save_new_objects() are useful in some ways.
One thing that I may have missed, but how are you dealing with save_new in BaseInlineFormSet? From a quick glance that would seem broken. > Yup, the tests pass. If I'm looking in the right places, the coverage > seems pretty bad. ModelFormSets and InlineFormSets are not tested at > all. Did you look at http://code.djangoproject.com/browser/django/trunk/tests/modeltests/model_formsets/models.py? > > Do you have a suggestion for not passing a queryset as the 'initial' > argument to FormSet? I'm thinking that either the queryset is > translated to a list of dicts like before, so the forms will have both > an instance and initial data, or BaseFormSet.__init__() should be > broken up so that _initial_form_count is set in another method that > can be overridden. I like the later. I think the better solution here is to keep the __init__ code the same but we need an instance level of the queryset persistent so we can use the use the caching it would provide. Then use the the indexing like you have with i local variable in _construct_form. -- Brian Rosner http://oebfare.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
