The one's that are a result of Oracle not returning a Decimal can be solved be inserting "..." before and after the number, in placeess of explicitly saying Decimal(unless of course this is actually a typecasting issue in Django itself, in which case that should be fixed) this is done a few other places in aggregates regress.
The SQL command not properly ended appears to be the result of an annotate call followed by a call to aggregate(). I don't have a clue what causes that as I've used Oracle in my life :) . Alex On Mon, Jan 5, 2009 at 10:14 AM, Karen Tracey <kmtra...@gmail.com> wrote: > On Mon, Jan 5, 2009 at 10:51 AM, alex.gay...@gmail.com < > alex.gay...@gmail.com> wrote: > >> >> Karen, >> >> Can you try changing line 230 of django.db.models.sql.query from: >> row = row[:aggregate_start] + tuple( >> to >> row = tuple(row[:aggregate_start]) + tuple( >> >> That should clear up most of the errors and seems to be the result of >> Oracle returning a list instead of a tuple. >> > > Yes, that gets rid of a bunch of errors. Remaining is a quartet > of "DatabaseError: ORA-00933: SQL command not properly ended" for > aggregation_regress: > > http://dpaste.com/105614/ > > and a few of those plus some other output differences, etc. for > aggregation: > > http://dpaste.com/105612/ > > (I'm assuming these are the only interesting tests to run. The full test > suite with Oracle on this machine will take 9 hours or so to run. That can > be improved to about one hour with the rollback testcases approach, but I > haven't yet tried applying the latest patch for #8138 on top of the > aggregate snapshot.) > > Thanks, > Karen > > > > -- "I disapprove of what you say, but I will defend to the death your right to say it." --Voltaire "The people's good is the highest law."--Cicero --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
