On Thu, Jan 15, 2009 at 10:33 AM, Marty Alchin <[email protected]> wrote: > While working again with files for model validation, I realized (and > confirmed with Russ, Honza and Alex in IRC) that the tests put in as a > fix for #6009[1] don't actually prove all the behavior that ticket > refers to. They prove that Unicode filenames come through fine from > uploads, but that test doesn't actually save the file at all. The > changes I'm working on for validation cause it to save the file now, > and the second part of that ticket (dropping too many characters from > the filename) comes back to bite us.
Correction: it was actually an error in the test that was causing the failure; the problem just wasn't evident until the changes I put through. I've put in ticket #10041 to address the problem with the test. > I'm not sure if get_valid_filename() needs to be as aggressive as it > currently is, because a bit of light reading suggests that we should > be able to work with Unicode filenames, now that Django passes around > Unicode strings properly throughout. Alas, I'm not an expert in > Unicode or file systems, so I don't know if I'm overlooking some > obvious problem with opening the range up to include Unicode > characters. This is still a problem, though it's not the cause of any test failures. The second part of #6009 is still a potential issue, and I'm still not sure how best to address it. I'm not going to reopen that ticket, though, nor will I open a new one until I know a bit more about how to continue. -Gul --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
