On Fri, 2009-01-30 at 20:30 -0800, Justin Bronn wrote: > > 2) F() expressions have not been updated to work with GIS fields. > > However, based on some initial discussions with Justin, it should be > > possible to make these changes without affecting any public API. If > > anyone with access and experience with contrib.GIS cares to help out > > on this front, assistance would be gratefully accepted; otherwise, > > we'll just have to wait until Justin surfaces from his Bar exams. > > Currently, nothing is broken and all tests pass -- only that a > TypeError is raised when one tries to use F() on a geographic field.
The main issue I flagged to Russell in some code review notes was whether the code needed to be able to handle get_placeholder() output, instead of hard-coding "%s" everywhere for parameters. If there were particular column comparisons that required a more massaged approach to getting the data out of parameters in some cases and if we had to feed the placeholder functions to the Evaluator or something similar. Maybe we don't -- at least, not right now and not for GIS -- which is fine, too. Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
