I decided to finally tackle this very old "easy" ticket.

http://code.djangoproject.com/ticket/4092

My updated patch is attached to the ticket.  I did not include the
original modifications to ModelChoiceField since that produced
failures in the forms tests and removing the empty_label option from
the constructor would not be backwards compatible.

If we do want to make ModelChoiceField use NullSelect instead of
Select widget, it would involve changing all ChoiceFields to use
NullSelect, and I don't think we want to do that.  Alternatively, we
could de-couple ModelChoiceField from ChoiceField.  I guess if someone
wants to use NullSelect as the widget for a ChoiceField or a
ModelChoiceField, they could specify it in the kwargs and empty_label
would effectively be ignored.

Thoughts?
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to