On Mar 12, 11:10 pm, Russell Keith-Magee <freakboy3...@gmail.com> wrote: > On Thu, Mar 12, 2009 at 8:31 PM, Julien Phalip <jpha...@gmail.com> wrote: > > > On Mar 12, 9:30 pm, Russell Keith-Magee <freakboy3...@gmail.com> > > wrote: > >> On Thu, Mar 12, 2009 at 7:20 PM, Julien Phalip <jpha...@gmail.com> wrote: > > >> > Hi, > > >> > A few months ago James raised the issue on this list: > >> >http://groups.google.com/group/django-developers/browse_thread/thread... > > >> > Basically, the type for the test client's response context is > >> > inconsistent. Sometimes it's a dictionary and other times it's a list > >> > of dictionaries, depending on whether or not the tested page was built > >> > with a hierarchy of templates. > > >> > I don't think this has been fixed yet. Could someone confirm? If it > >> > hasn't, then does it have a chance to make it into 1.1? I haven't been > >> > able to find any ticket for it, should one be created? > > >> The status of this issue hasn't changed. It hasn't been fixed. There > >> isn't an existing ticket to the best of my knowledge. As Jacob noted > >> the last time you asked, this is a relatively small change, so if a > >> suitably complete patch were to materialize out of the ether, it would > >> probably find itself in trunk for v1.1. > > > Thanks Russ. I'm keen to have a go at it during the upcoming sprints. > > You and Jacob say it's a small change. Could you please give a hint on > > what that is? Just so that I have something to start with and so I can > > pull off the groundwork more quickly. > > James (Bennett) pretty much described what needs to happen - it hinges > on adding __getitem__ operator for the context object which is > sensitive to whether the context is being subscripted by integer or by > string. i.e., > > request.context[3] will get the third context in the stack > request.context['foo'] will try to find the key 'foo' in the context. > > James gave a bit more detail in his post.
Makes perfect sense. I created a ticket for it (#10482) and will start with a patch soon. Cheers, Julien --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
