On Thu, 2009-03-19 at 19:30 -0700, Ulrich Petri wrote: > Hi, > > since #9666 (SSI-tag variable resolving) got accepted by Jacob lately > I would like to restart discussion about the same functionality for > the url template tag (as was already proposed in #7917). > > Pro arguments: > - The url tag is one of the few remaining tags that doesn't accept a > variable as it's "main" argument and is therefore inconsistent > behaviour. > - Allowing variables would enable the use in inclusion tags (e.g. a > pagination inclusion tag which takes a view name as argument - leading > to cleaner urls without get parameters with is beneficial for caching > etc.) . > - Generally reducing DRY in templates with similar content but > different links. > > Contra arguments: > - Possible name clashes between views and template variables. > - May possibly lead to difficult to track down behaviour.
I was one of the original people in favour of making this change, but since it was decided not to go down that path (disappointingly, it seems, mostly through apathy at the time), I think we shouldn't change it now. the fact that it will either require a backwards-incompatible syntax change or lead to ambiguity as to whether a view or string is intended is a big enough negative to think it's not worth doing. Particularly a you're proposing a system that changes the behaviour in every single release for the next three releases. Make no mistake, I would love to fix it properly, but I think the better approach is to introduce a new tag and then deprecate the old one, where the new tag handles strings consistently. Certainly right now is not the time to do it. This needs a discussion, but we also have a lot of 1.1 things needing discussion. Work on making your patch perfect, but let's postpone the design discussion until 1.1 is out the door, when we have time to focus on things a bit more. Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
