Hey Joseph, On Mon, 2009-03-23 at 15:32 -0500, Joseph Kocherhans wrote: > #9284 [1] Has a patch to make BaseModelFormSet call ModelForm.save() > when saving objects rather than using completely custom code as it > does now. I think this is the "right thing (tm)" to do, but it will > break people's code who have overridden the formset's __init__ method > and mucked around with the "initial" argument. I don't really feel bad > about said breakage, because hey, you're messing with internals, you > should know what you're doing.
I've looked at this briefly. I haven't got a strong opinion about the effects of the backwards incompatibility yet (although I've been thinking about it in odd moments since I saw you post that patch), although your logic isn't totally from Outer Space. The approach looks better. I'd be tempted to lift a couple of those leading-underscore methods up to just being normal methods. Found myself having to override a few of those things lately when wanting to use the formset infrastructure in other ways. It won't kill us to allow inital-, total- and management-forms getters to be overridden, I don't think. Regards, Malcolm --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
