On 15 Apr 2009, at 22:25, Karen Tracey wrote:
>> So am I missing something or should this be changed?
>
> TestCase testcases should not be running after TransactionTestCase  
> testcases.  I had this concern prior to checking in the test changes  
> (see 
> http://groups.google.com/group/django-developers/browse_thread/thread/1e4f4c840b180895/)
>  
>  and (thought) I addressed it by adding code to reorder the test  
> suite after all the tests are discovered so that all TestCase  
> testcases (which assume a clean DB on entry and ensure one on exit)  
> are run first.  It's even documented 
> (http://docs.djangoproject.com/en/dev/topics/testing/#django.test.TransactionTestCase
>  
> ) since the reordering revealed a few testcase-order dependent bugs  
> in the Django test suite so might also cause hiccups for people with  
> their own suites when upgrading to 1.1.

Ah, so that's what I was missing. That does ring a bell now you  
mention it, I was reading some of your discussion of this at the time.

> Are you actually seeing TestCases run after TransactionTestCases?

I am seeing this, however I am using the GIS test runner which doesn't  
have the reordering code.
So the correct solution instead of what I suggested is for me to work  
up a patch for the GIS test runner that uses your reordering code.

Thanks,
Sean

(PS I've hit another issue with the new-style TestCase to do with  
using the transaction decorators, but I'm more confident that I know  
what's going on with that so I'm preparing a ticket about it with a  
patch right now).

-- 
Sean Legassick
[email protected]




--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to [email protected]
To unsubscribe from this group, send email to 
[email protected]
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to