Hi Marc, On Mon, Jun 8, 2009 at 4:06 PM, Marc Garcia<[email protected]> wrote: > [...] I'll really appreciate your comments, specially the ones complaining > about the code or the way I'm doing something. [...]
IMHO; Not very important but I'd strip the "Default ...." part of the settings comments, even from the pre-existing ones; Only date related settings have this "Default ..." prefix in it's comments and feels very repetitive, we all know global_settings is about defaults. Also, those functions that are going to be deprecated should raise some DeprecationWarning to make sure anybody using them for something gets warned. Also makes it easier for the release+1 to spot thing to remove. I am wondering.. Maybe that's being discussed before, but anyway: >From what I see you intend to have a conf/locale/XX/formats.py being XX the language codes, if this is the case, how will you allow further customization? I mean, right now one can place custom .po files in his/her project path and override Django provided translations, that new behaviour seems to make it hard (if not impossible) to override the date/time (or any other formatting) related translations on a per-locale basis. That goes toghether with allowing per-application "format strings". Nice work! Just my 0.02, Marc -- http://www.marcfargas.com - will be finished someday. --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
