Sigh! I guess I sent this out a little prematurely. On Wed, Aug 12, 2009 at 3:50 PM, Waylan Limberg<way...@gmail.com> wrote: [snip] > > 2. Implement ticket #11625 -- Add admin actions to the comments admin. > [snip] > > 3. Using a proxy model and custom manager, create a second admin > instance which only lists comments in moderation and offer the > same admin actions as in 2 above. > [snip] > > 4. Incorporate the existing views into the admin by extending the > base get_urls() method to point to them. > [snip] > > The other piece that is missing IMO is a way to make those admin actions > available on an individual comment. Some times, one actually needs to > read the comment to know if it is spam or not. [snip]
Actually, implementing option 4 would accomplish this. The fact is, the existing (undocumented) list view is not needed in the admin as option 2 or 3 would fill that need. Therefore, the only views that we would need to map to admin urls would be the `approve` and `remove` views. We just need a custom template for the add/change view which adds the respective buttons next to delete, save, etc. The common code between the admin actions and the approve & remove views could be factored out into a couple utility functions which, along with the proxy model with custom manager (from option 2) would provide enough for some one to implement there own non-admin solution. That is, if that is even a goal. So, the question is, whether we go with option 2 or 3 (and add option 4), do we want to remove the existing undocumented views and templates for listing and acting on the moderation queue? Or do we want to leave them in (and undocumented) as an example of how it could be done? Of course, I'm assuming we are not concerned about backward compatibility as none of this has yet to be documented. However, if might be nice to depreciate it first for those who dug into the code and are using it. -- ---- \X/ /-\ `/ |_ /-\ |\| Waylan Limberg --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
