On Tue, Oct 13, 2009 at 9:48 AM, Jacob Kaplan-Moss <ja...@jacobian.org> wrote: > This is my main concern, and the thing keeping me from being > enthusiastic about the current state of the proposal. Many apps -- > including, notably, django.contrib.admin -- rely on user.message_set. > We can't simply remove it; we need to follow a deprecation schedule. > But we also shouldn't just keep two parallel "messaging" > implementations; that's silly. > > The best solution, I think, would be to implement user messages > (user.message_set, get_and_delete_messages, etc) in terms of the new > framework, and then gradually deprecate and remove the old APIs.
I think this is a large reason why the original attempt to get this ticket fixed fell apart: User messages and session messages are two completely different beasts and trying to fit them into the same API is somewhat of a dead end. The proposed app would function better for contrib.admin than what exists now, so I'm confident that if we introduce/deprecate in a gradual way the necessary changes can be made easily and on a reasonable schedule. I don't envision updating the admin in this release but someone correct me if there's an issue with not doing it right away. I'm not sure exactly what you mean by implement user messages in terms of the new framework. It is completely possible to implement a storage engine in several of the proposed solutions that would use user.message_set to store data, though I'm not sure what the advantage would be over any of the other options. Furthermore, the fact that user.message_set is just a related manager on a model and not an independent API per se makes it a difficult one to remove while simultaneously keeping user message functionality. Unless there is a compelling use case for user-based messages that really sets it apart from the proposed app (and there may very well be, I just haven't heard it yet), my vote is to deprecate the Message model in contrib.auth in a gradual way and remove it altogether several releases down the road. Tobias -- Tobias McNulty Caktus Consulting Group, LLC P.O. Box 1454 Carrboro, NC 27510 (919) 951-0052 http://www.caktusgroup.com --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
