On Oct 16, 8:54 pm, Russell Keith-Magee <freakboy3...@gmail.com> wrote: > On Sat, Oct 17, 2009 at 6:00 AM, Gabriel Farrell <gsf...@gmail.com> wrote: > > > I hate to waste time talking about the tools rather than the product, > > but I'm frustrated by my inability to get my patches displaying nicely > > in the Django code trac. > > Seehttp://code.djangoproject.com/attachment/ticket/11250/admin_can_delet... > > -- produced by "svn diff > admin_can_delete.diff". The "original > > format" appears to be a correct diff file. Why isn't it displaying? > > Ah Trac, how we do love you :-) > > This is a known problem with Trac, with a number of causes. In your > case, I suspect it will be the "No newline at end of file" marker in > generic_inline_admin/tests.py. For some reason, Trac doesn't like > those markers. If you try adding a newline to the file and > re-uploading the patch, you may find the patch is displayed.
You were correct -- the "No newline" marker was the problem. Since I had added the newline, however (vim does so automatically), the fix was to remove the marker line from the patch file. > However, this is something that falls into the category of annoyance, > rather than actual problem. We can still download the patch, we just > can't review it online. As a result, it hasn't been a huge priority to > find a solution. Agreed, it's only a minor annoyance, but good to have it resolved in this case. Thanks for the help! Gabriel --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
