On Thursday 22 October 2009 04:41:03 Tobias McNulty wrote:
> In sticking with the staged deprecation policy, my vote would be:
> * use compat_add_message() internally in 1.2. There is no need to
> document this function as request.message_set.create will continue
> to work.
> * in 1.3, remove compat_add_message and raise an error if
> 'messages' isn't enabled when you try to use the admin or
> create_update generic views, etc.
I think this is the right approach. The second branch of
compat_add_message should raise a DeprecationWarning that indicates
that the 'messages' app will be a dependency of the admin and generic
views, since the user's code is going to break if they update to 1.3
without fixing their settings. Obviously the release notes for 1.2
and 1.3 need to detail this - you can start to add things to
doc/releases/1.2-alpha.txt
I've started to look at the code, and have some other minor
suggestions, but not significant things to do with approach, so I'll
e-mail you personally with them at some point. On the basis of what
I've seen so far, I'm willing to change my vote on this to +1, which
at the moment would make me the 'champion' for this feature, as no-one
has voted -1. At the moment, the big areas that are lacking are:
- user docs
- code docs (I'm curious about things like EOFMessage, there
is nothing to explain why it exists).
- changes and complete tests for the auth context processor,
including the different configurations that are allowed
(with and without the messages app, for instance). I think
the auth context processor should call the messages one,
so that you get the same result whether you use one or
the other or both.
Luke
--
Carpe post meridian! (I'm not a morning person.)
Luke Plant || http://lukeplant.me.uk/
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com
To unsubscribe from this group, send email to
django-developers+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/django-developers?hl=en
-~----------~----~----~----~------~----~------~--~---
