On Tue, Nov 3, 2009 at 1:27 PM, Andi Albrecht <[email protected]> wrote: > > On Mon, Nov 2, 2009 at 4:53 PM, Jacob Kaplan-Moss <[email protected]> wrote: >> >> On Mon, Nov 2, 2009 at 10:02 AM, Russell Keith-Magee >> <[email protected]> wrote: >>> A quick reminder - if you have any objections or feedback on #10109, >>> the M2M refactor [1], I intend to land this patch in approximately 48 >>> hours. >> >> I've left a few comments in that thread, but they don't need to be >> addressed pre-merge. Fire away! >> >>> Also, following some mailing list and IRC discussion [2], I'll be >>> trying to land #10355 at the same time. This is the addition of the >>> email backend API. >> >> I've left a few notes on the ticket. The only one that needs to be >> addressed pre-merge is a simple design decision, and the final call's >> yours. > > Russel, thanks for finishing the mail backend patch! Jacob's notes on > the ticket sound very reasonable to me - please let me know which of > them you'll address before merging. I'd be happy to provide a patch > for anything remaining.
I've already integrated Jacob's comments into the code in my local checkout. Actually, Jacob's comments pointed out an interesting code cleanup: the File email backend is really just the Console email backend pointing at a file object instead of stdout. As a result, I've been able to delete a bunch of code by modifying the console backend to accept an arbitrary stream, and making the file backend a subclass of the console backend. I'll commit tonight (my time) once I have a chance to give the patch a final review. Thanks for your work on this patch Andi, and everyone else that has contributed feedback and comments. Yours, Russ Magee %-) --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [email protected] For more options, visit this group at http://groups.google.com/group/django-developers?hl=en -~----------~----~----~----~------~----~------~--~---
