Hi Russell, Thanks for the review :)
> * The DEFAULT_TIME_INPUT_FORMATS strings have been removed from the > forms/fields.py module. I know they are no longer required, but they > were previously public symbols. I suspect we need to leave them in, > but mark them as deprecated in docs. Ideally, we would be raising > deprecation warnings if anyone referenced those settings, but I'm not > sure that will be easy to achieve. Yep, I added throws deprecation warnings for module imports in http://github.com/jezdez/django/commit/fc67ad68835dafa84aa33f8e7d2e98e66b89ed77 > * Speaking of which, the patch doesn't contain any entries for the > deprecation notes or the 1.2 release notes. A minor issue, but > necessary. True, I'll add some. > * The docs talk about the fact that USE_FORMAT_I18N requires USE_I18N > to be true, but I'm not sure I see why this is necessary. The two > ideas are clearly conceptually linked, but I'm not sure I see why we > need to enforce the dependency. It's not too hard to think of a case > where you don't need to translate, but you might need to localize - > Australia is one obvious example, because we generally use DD-MM-YYYY > for dates, but US English translations are usually fine. Good point, for what it's worth the formatting depends on the "current language" as detected by the i18n framework, which will fall back to the LANGUAGE_CODE setting in case USE_I18N is set to False. So we could indeed remove that hard dependency. > * To that end, should it be USE_FORMAT_I18N, or USE_FORMAT_L10N (or > just USE_L10N)? Again, my (mostly uninformed) inspection, the issues > addressed by this patch are L10N issues, not I18N issues. I'm not entirely sure about the subtleties of those terms, mostly because we haven't used "L10N" in Django yet, even if we provided some abilities to localize variables depending on the locale (e.g. the *_FORMAT strings in the translation files). So maby it's time to call a spade a spade, I mean USE_L10N :) Jannis -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
