On Jan 27, 10:14 am, Russell Keith-Magee <freakboy3...@gmail.com>
wrote:
>
> It isn't a simple patch. it's a 37k, 800 line diff.

Yes, although the length of the patch is not much of a clue about its
complexity (which is quite low IMO).

> It isn't really backwards compatible, either. It fundamentally changes
> the assumption about whether you can rely on settings.INSTALLED_APPS
> as a list of strings of installed applications. If you have a reusable
> app that relies on INSTALLED_APPS being a list of strings, your
> application will break.

Absolutely. The patch does provide a drop-in replacement for
settings.INSTALLED_APPS, i.e. settings.get_installed_app_paths(),
using which is a search+replace exercise. Actually much of the patch
size is due to replacing occurrences of INSTALLED_APPS with
get_installed_app_paths(). Of course, if one is using third party
apps, this means having to change settings.INSTALLED_APPS in those
apps as well, which is not ideal :-(

Also, I haven't merged this patch with trunk for almost a year, so
it's not necessarily "good to go" without at least doing that. Perhaps
when I get a bit of time, I'll be able to look at it...

Regards,

Vinay Sajip

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-develop...@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to