On 27 Jan 2010, at 22:50, Ben Firshman wrote: > > On 27 Jan 2010, at 15:36, Russell Keith-Magee wrote: >> >> However, my initial impression: one way to dramatically increase your >> chances is to make sure the patch applies to trunk, and passes all the >> tests. Neither of these things are true at present. Using the most >> recent patch on the ticket, I currently get 4 patch failures. Once I >> fix those the way I suspect they are meant to be fixed, I get a failed >> test case (SyndicationFeedTest.test_add_domain). > > Oh gosh, sorry, I thought I fixed all those problems. I'll get it fixed > against trunk this evening.
http://code.djangoproject.com/ticket/12403 I've added syndication-view-6.diff which should apply cleanly against r12313, fixes that test and has a few documentation tweaks. You can see a working pretty diff on github: http://github.com/bfirsh/django/commit/1fac8441b49f690094026fb06189d4f12babac4e Ben -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
