On Sat, May 1, 2010 at 1:57 AM, Mike Axiak <mcax...@gmail.com> wrote: > On Fri, Apr 30, 2010 at 11:56 AM, Russell Keith-Magee > <freakboy3...@gmail.com> wrote: >> So, if we were to integrate a code review tool, it would only be to >> support case 3. I don't have any concrete numbers to back me up, but >> my gut feeling is that case 3 isn't a time sink for me. > > There is an added benefit to having a code review tool, though. I > think you'll find that people who post one patch are more likely to > post another patch. Using a code review tool will help those patch > writers to more quickly learn the ropes of writing good Django code > and improve. > > It may not be worth the added effort by the commiters, but it is > something to keep in mind.
That's a valid point - this is one of those cases where it creates more work for the core (providing formal review feedback on patches that are almost correct, rather than just fixing them and committing), but in the long run giving that feedback might be worth it. Although a code review tool might make the review process easier, there's nothing in particular preventing committers from providing feedback using the tools we have right now. I'll try and provide better feedback on patches that get committed. If it turns out to be a useful exercise rather than just busy work, it might provide some extra incentive to get a code review tool in place. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
