On Wed, Aug 4, 2010 at 6:52 PM, David P. Novakovic <[email protected]> wrote: > Hey, in the interest of easing myself into helping out I've picked an easy > ticket to get done. > http://code.djangoproject.com/ticket/12074 > I've fixed the patch and added tests. > Let me know if I've missed something, or done something wrong :) > Cheers, > David > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to [email protected]. > To unsubscribe from this group, send email to > [email protected]. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. >
Hey David, Thanks for contributing! The one reccomendation I'd make is to change the doctests into unittests. I realize a ton of the formsets tests are doctests, however in general we're trying to move away from them for a number of reasons (mostly that they're a pain in the ass to debug). If you could switch those to be unittests I'll mark it as RFC. Alex -- "I disapprove of what you say, but I will defend to the death your right to say it." -- Voltaire "The people's good is the highest law." -- Cicero "Code can always be simpler than you think, but never as simple as you want" -- Me -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
