Hi all. I'm not a django core developer but have some thoughts about provided patch.
1. The patch is for django 1.1 and django 1.2 have jQuery available so some parts may be simplified. 2. Some 'var' declarations are missing (check 'dismissChangeCurrentPopup' method and 'i' variable, 'href' and 'element' variables in 'showChangeCurrentPopup' function). This will pollute global namespace and can cause weird bugs in future. 3. I don't understand some code: what is 'element = document.getElementById(element_id);' declaration for in 'showChangeCurrentPopup' function (and 'elem = document.getElementById(toId);' in 'dismissChangeCurrentPopup'). 4. Permissions are not checked. It should be mentioned that Django 1.2 now has row permissions foundation. Regards, Mikhail. On 7 авг, 00:46, "dharmesh.patel.eif...@gmail.com" <dharmesh.patel.eif...@gmail.com> wrote: > Hello, > > http://code.djangoproject.com/ticket/11397 > > As I already implemented it for Django version1.1 but still there is > no action or feedback on it. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
