How often should I ping, so my patch won't be forgotten? :) On Thu, Aug 19, 2010 at 9:38 AM, Jannis Leidel <jan...@leidel.info> wrote: > Am 19.08.2010 um 01:50 schrieb Waldemar Kornewald: > >> No comments means it's still not good enough and I'll never get it >> into an acceptable shape? :) > > No, in that case we would tell you :) It's much more likely that nobody had > time yet (in the last 3 days) to look at your patch thoroughly. > > Jannis > > >> On Sun, Aug 15, 2010 at 7:13 PM, Waldemar Kornewald >> <wkornew...@gmail.com> wrote: >>> On Sat, Aug 14, 2010 at 1:45 PM, Waldemar Kornewald >>> <wkornew...@gmail.com> wrote: >>>> On Thu, Jul 22, 2010 at 4:30 AM, Russell Keith-Magee >>>> <russ...@keith-magee.com> wrote: >>>>> I accept the need for this, but this seems like a bit of a wart. This >>>>> method wouldn't be required at all if the Form took a request >>>>> argument. This isn't an unusual requirement, either -- perhaps we >>>>> should introduce a RequestForm/RequestModelForm that formalizes the >>>>> availability of the request object during form processing. >>>> >>>> OK, I've now added a Request(Model)Form. The tag is based on >>>> <cls.__module__>.<cls.__name__>, so you don't have to manually specify >>>> it. FileField takes an optional parameter to override this. Forms >>>> currently only allow to set the tag by subclassing. Not sure if this >>>> is sufficient. >>>> http://code.djangoproject.com/attachment/ticket/13960/filetransfers.3.diff >>>> >>> >>> Now I've finished admin UI support for the proposed API: >>> http://code.djangoproject.com/attachment/ticket/13960/filetransfers.4.diff >>> >>> If you want to see a more practical example, the following >>> demonstrates an async upload process (like with S3 or App Engine): >>> http://bitbucket.org/wkornewald/upload-sample-trunk-filetransfers >>> >>> The same async upload process is used in the admin UI. If you submit a >>> file from within the admin UI the file first gets sent to a view at >>> /upload and then the request gets forwarded to the actual admin view. >>> Also, the backend changes the file download URLs (even in the admin >>> UI) to point to the download view at /download. >>> >>> BTW, if you're too busy/lazy to apply the patch you can just clone my >>> Django development branch: >>> http://bitbucket.org/wkornewald/django-trunk-filetransfers >>> >>> Bye, >>> Waldemar Kornewald >>> >>> -- >>> Django on App Engine, MongoDB, ...? Browser-side Python? It's open-source: >>> http://www.allbuttonspressed.com/blog/django >>> >> >> >> >> -- >> Django on App Engine, MongoDB, ...? Browser-side Python? It's open-source: >> http://www.allbuttonspressed.com/blog/django >> >> -- >> You received this message because you are subscribed to the Google Groups >> "Django developers" group. >> To post to this group, send email to django-develop...@googlegroups.com. >> To unsubscribe from this group, send email to >> django-developers+unsubscr...@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/django-developers?hl=en. >> > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-develop...@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en.
-- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
