On Sep 28, 3:42 am, Luke Plant <[email protected]> wrote: > But can anyone else think of any gotchas with this change before I > commit it? It produces a 30% improvement for the benchmark that relates > to the ticket [3].
Not directly related to this change, but there are at least one part in Django that will cache a setting when first used [1]. The code in django/utils/translations/__init__,py will cache the real translation provider for performance reasons. If the USE_I18N setting is changed when testing, it will not have any effect in which translations provider is used. There might be other parts also which do the same thing. I wonder if __setattr__ of the LazySettings should automatically flush this cache when USE_I18N is changed? [1] http://code.djangoproject.com/changeset/13899 - Anssi -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
