After r13980, GIS sitemaps were broken, and when attempting to fix I had questions about the underlying implementation of the changeset:
http://code.djangoproject.com/changeset/13980/django/trunk/django/contrib/sitemaps/views.py In the loop iterating over the `sitemaps` argument (L12), the `site` value is a global Sitemap (or subclass thereof) instance typically defined in a user module. While adding the missing `site.request = request` assignment in the GIS sitemaps code enables tests to pass -- this solution appears thread unsafe because we are assigning, on a per- request basis to the sitemap view, the `request` attribute to a module- level global. What if two different search engines request the sitemap index at the same time? Each would be clobbering over the `request` attribute for the other, producing inconsistent sitemaps. First, I'd like more eyes to confirm/deny my interpretation here. Second, if this is confirmed, how should we solve it -- the situation is compounded by the fact this changeset fixes 7 tickets. Luke, is there anyway to decouple this from fixes for the other tickets? -Justin -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
