On 19 October 2010 05:10, Russell Keith-Magee <russ...@keith-magee.com> wrote: > On Tue, Oct 19, 2010 at 10:29 AM, Will Hardy <e.willha...@gmail.com> wrote: >> Whilst I agree that messing with contrib.auth is likely to break >> something and create more work, I think it would be good for Django if >> everyone in the Django community went and needlessly ported their real >> world views to CBV, to expose any deficiencies in the framework before >> release. >> >> Even if the rewritten auth app isn't merged to trunk (yet), I imagine >> it could be useful in testing the boundaries of the fresh framework. >> If someone wants to put some hours on porting code that won't be >> included, but has the off-chance of improving the CBV framework, it >> would be very noble of them :-)
I just kinda volunteered to do this, so I you send some code my way, I'll take a look at it during the weekend. > I share Jacob's concern about making change for the sake of change. > This is especially important with contrib.auth. There have been long > running conversations about "fixing" contrib.auth to make it more > flexible. Since making contrib.auth more flexible may well involve > changes to the auth views, it would be premature to make changes now, > only to require more (potentially incompatible) changes in the near > future. I fully agree. It wasn't my intention to get this change into the core, although it would make customizing views there a bit more civilized. > > However, as an academic exercise, I agree that it's worth exploring. > contrib.comments would be another app that would benefit from an > academic exploration -- it's a complex collection of views that would > lend itself to subclassing. > > Plus, some preliminary work now might provide a good base when we *do* > work out what changes need to be made to auth views. > Yes, this is mostly an academic exercise, so I'll take a look at contrib.comments too. -- Łukasz Rekucki -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
