On Mon, Oct 25, 2010 at 1:31 AM, oggy <[email protected]> wrote: > Hi, > > would any of the commiters consider marking the patch in #11035 > (urlify.js with Serbian alphabet) as "ready for check-in"? It's > important for Serbian i18n, but it's been sitting there for over a > year. The patch shouldn't be controversial at all (it's not perfect > but it's a significant improvement over the current situation). It > wasn't accepted for 1.1 as it was reported too late, so just trying to > make sure it avoids the same fate for 1.3.
The Ready For Checkin tag doesn't need to be handled by a committer -- in fact, we rely on the community to do this triage and point us at tickets that are ready. This person who does the triage doesn't need to be anyone in particular. It just needs to be someone other than the patch submitter (and in this case, someone who speaks Serbian). The other reason the patch hasn't progressed is that it isn't in a format we can easily use. We prefer context diffs generated against the root of the source tree, not 'ed' format diffs of a single file. >From a pure content point of view, the patch looks fine, assuming the Cyrillic mapping is accurate. It's also preferable to the patch on #14345 due to the fact that it doesn't change the ordering of ALL_DOWNCODE_MAPS. If you update the patch to be a context diff, and get another Serbian speaker to review it, it can progress. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
