On Thu, Oct 28, 2010 at 6:59 AM, George Vilches <[email protected]> wrote: > > > On Oct 27, 5:55 pm, Jacob Kaplan-Moss <[email protected]> wrote: >> On Wed, Oct 27, 2010 at 4:32 PM, Adrian Holovaty <[email protected]> wrote: >> > I'm inclined to say we do the former -- restore the "ne" lookup type >> > -- because it's a quick fix, and ask somebody to write up a patch for >> > the latter. Does anybody have strong opinions against this? If not, I >> > can restore the "ne" lookup type. >> >> Sounds like a good plan to me (especially making simple excludes faster). >> >> However, just for the record I think the reason we decided to remove >> __ne is the first place was that its existence introduces a weird >> inconsistency with regard to other lookup types. That is, if there's a >> "ne" why isn't there a "nstartswith" or "nrange" or ... ? I think down >> that path lies madness so I'm +0 on bringing back "ne" with the >> proviso that we agree it's not the first step down a slippery slope >> towards "nistartswith" and friends. > > I know it's been a little while since I've made any major ORM > contributions, but I'd say -0 on __ne, and +1 on making exclude > generate better code. Django's worked far too hard on making things > consistent as possible to let like this slip by just because we don't > want to muddy our hands with a little harder work in the exclude() > code.
I agree. We should certainly fix the behavior of exclude(), but reintroducing __ne feels like the start of a slippery slope to me. Conceptually, I'm -1 on reintroducing __ne. In the interests of practicality, I'd be willing to reconsider if it turns out that fixing exclude() is prohibitively complex. However, it seems premature to reintroduce __ne as a stop-gap measure before anyone has taken a serious look at what is involved with fixing exclude(). We still have almost 3 months until the freeze for 1.3; that should be plenty of time to investigate exactly how much work would be involved in fixing this bug properly. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
