On 11/02/2010 01:09 AM, Russell Keith-Magee wrote:
- The base class refactoring makes sense, although what you're proposing isn't really just a 'BaseDB backend', but a 'backend that has to implement culling'. The reason I can say this is that the logic you have factored out is duplicated in the filesystem and local memory backends (but not the memcache backend).
I have to admit I only looked at the database backend :-)
- Regarding the test case for culling -- is there any reason that the test case can't just set self.cache, rather than adding the argument to the test method?
Of course not, I just didn't think of that.
Lastly, rather than handling this as two patches, I'm happy for this to be submitted as a single patch under a "refactoring for the benefit of non-db cache backends" moniker.
Here you go: http://code.djangoproject.com/ticket/14596 Jonas -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-develop...@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
