On Mon, Jan 10, 2011 at 11:25 AM, Chris Haines <[email protected]> wrote: > Hi Everyone, > I would like to start contributing patches to django and I had a question > about how to handle ticket #14176. The gist of it is that the > settings.feeds dictionary changed from using a class object for values to > using an instance object. I can fix this bug but should the old format > using a class object be considered deprecated? If so, is there any > documentation on how to mark certain code as deprecated?
First off -- thanks for helping out on a release-blocking bug! You help is much appreciated. As for the bug itself: we need to be clear on what exactly happens with deprecation in Django. When Django deprecates a feature, code using that feature should continue to work as-is, without modification, for two more releases. The problem reported by #14176 indicates a case where it does not. In this case, Django 1.2 introduced a new format for describing feed instances. If you have code using the old-style view-based format, that code should continue to work. However, this code should raise PendingDeprecationWarning. You may not see this warning unless you've turned on all warnings (PendingDeprecationWarning is silenced by default), but if you look at the definition of feed() in django.contrib.syndications.views, you will see that whenever you actually call the view, a warning will be raised. In Django 1.3 (i.e., current trunk), the PendingDeprecationWarning is promoted to a full DeprecationWarning. By default, this isn't silenced, so it should be a lot more obvious. In Django 1.4, support for the old-style view will be removed entirely. In this case it appears that there is something about the comments framework that prevents the old-style syndication views from working as expected. Fixing this bug isn't just a matter of making the comments feeds work as a class-style representation -- we need to understand why it doesn't work as a view-based registration. We have tests (in regressiontests/syndication) that demonstrates that old-style view-based registration does work; we need to understand what Comments feeds do that our tested paths don't do. We also need to add a test case that validates that an old-style view registration will work for comments feeds. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
