Hi Andrey I haven't yet looked through all of your code, but already a little feedback.
Remember that every dot operator requires a dictionary lookup or getattr call. Also the [ ]-operator is another level of redirection. I think using 'self' inside a for-loop is not a good idea. If you're going to compile, you really want to optimize every possible detail. On Mar 31, 6:00 pm, Andrey Zubko <[email protected]> wrote: > ... > def super(self,key): > if len(self._levels) > 1 : > for level in xrange(1,len(self._levels)) : > if self._levels[level].has_key(key) : > return self._levels[level][key] > else : > if self._levels[0].has_key(key) : > return self._levels[key] ### You mean: return > self._levels[0][key] > else : > return "" Maybe turn it into this: > def super(self,key): > levels = self._levels > if len(levels) > 1 : > iter = levels.__iter__() > iter.next() # Ignore first item > for level in iter: > if level.has_key(key) : > return level[key] > else : > return levels[0].get(key, "") Now you have only one lookup in 'self', half the amount of index operators (has_key counts as index operator), no additional xrange iterator, and only one call of "len". Gaining probably twice the speed. But is it really necessary to use classes and instance methods instead of just plain methods in a module? A template should be stateless. (we have render_context for the state when required.) Classes always have overhead compared to methods. -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to [email protected]. To unsubscribe from this group, send email to [email protected]. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
