On 31/05/11 14:55, Alex Gaynor wrote: > I came up with an alternate approach that is much > simpler: http://paste.pocoo.org/show/398303/ , all tests pass with this. > Any objections to checking this in?
This is much better than my attempt, but I spotted some problems. This line seems to have a bug in it: 'perms': lazy(lambda: PermWrapper(get_user()), PermWrapper)(), The 'get_user()' call should be replaced with 'user', I believe. I then realised that all the auth context processor tests were not running. I've fixed that now - so the tests mean something! There was a little more to clean up. I think we can remove 'partial' in favour of 'lambda' for simplicity, and we can remove LazyUser. My revised patch would be: http://paste.pocoo.org/show/398369/ I'm certainly happy with this approach, an improvement all round. I didn't run the whole test suite with this patch yet. Regards, Luke -- "The truth will set your teeth free." (Calvin and Hobbes) Luke Plant || http://lukeplant.me.uk/ -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.