2011/11/27 Mikołaj Siedlarek <mikos...@gmail.com>: > Hi, > I've just posted a new ticket with everything the feature proposal needs - > motivation, idea and actual implementation. > https://code.djangoproject.com/ticket/17301 > > It definitely needs some discussion, so please -- ask, discuss, criticize, > share some thoughts and one day, hopefully +1. :)
Hi Mikołaj, You won't get any argument from me on this one. In my ideal world, Django's admin should just be a light customization of Django's native form capabilities, tied to some nifty model introspection logic. However, as currently implemented, there are plenty of features -- like fieldsets -- that are only available to admin forms. Refactoring this code out of admin, and into base forms is certainly something worth pursuing. Also worth keeping in mind is the intersection of this sort of refactoring with efforts to replace Django's form rendering with a template-based renderer. This was the subject of a Google Summer of Code project this year, and while it hasn't been merged to trunk, there's some obvious potential for overlap with any plans to introduce fieldsets into base forms. >From an quick inspection of your patch, you look like your on the right track -- you've certainly got all the right pieces (tests, docs, and what appears to be a solid initial implementation). The only thing that I would like to see is an attempt to eat our own dogfood -- i.e., to try and replace the admin's custom fieldset tools with this new capabilitiy. Dogfooding is an important step in demonstrating that you've got the API right; given that this is something that is being factored out of admin, actually using it in admin would be a good proof of that concept. Thanks for the great contribution! Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
