On Wed, Dec 7, 2011 at 4:03 PM, Ian Clelland <clell...@gmail.com> wrote:
> > > On Wed, Dec 7, 2011 at 12:48 PM, Alex Gaynor <alex.gay...@gmail.com>wrote: > >> It's a fine goal, though I'm not convinced this should necessarily ship >> with Django given PyMySQL has relatively few users. > > > Agreed; I just don't know of another way to support Python 3 and MySQL, > without pushing the MySQLdb developers to add support. (This is the Python > 3 upgrade catch-22, and I'm looking for a way out of it). > > >> However, the approach is the wrong one, django database backends should >> be really split up between the parts that are database specific, and the >> parts that are driver specific, > > > Do you mean to say that putting support for two drivers in > django.db.backends.mysql is wrong, or that the django backends need to be > refactored? > > I had started off by writing a new backend, mysql_pymysql (in the spirit > of postgres_psycopg2), but there is so much overlap that it didn't make > sense to me to have to duplicate all of the code in a separate module, when > most of what I was doing was just changing the imports at the top of > base.py and introspection.py. > > I would be happy putting this out as a separate backend, which just > imported all of its functionality (and future bug fixes) from > django.db.backends.mysql, but I can't even import the django backend > modules in an environment which doesn't have MySQLdb installed -- say, any > Python 3 environment. > > I'll think some more on it, but if you have any architectural suggestions, > I'm very open to them. > > >> that way someone can write an external driver that uses, say, the >> postgresql spcific stuff but make it run on the 500 other postgresql >> drivers. >> >> Alex >> >> > Ian > > > > -- > Regards, > Ian Clelland > <clell...@gmail.com> > > -- > You received this message because you are subscribed to the Google Groups > "Django developers" group. > To post to this group, send email to django-developers@googlegroups.com. > To unsubscribe from this group, send email to > django-developers+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/django-developers?hl=en. > I'm saying database backends need badly to me refactored to split up these two seperate concerns. Alex -- "I disapprove of what you say, but I will defend to the death your right to say it." -- Evelyn Beatrice Hall (summarizing Voltaire) "The people's good is the highest law." -- Cicero -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.