On Mon, Dec 19, 2011 at 10:50 PM, James Pic <james...@gmail.com> wrote: > Hello everybody, > > I've fixed very little code in django admin (inlines.js, actions.js) > which makes it forward compatible to jQuery 1.6. > > I'm willing to share it, i created a ticket > https://code.djangoproject.com/ticket/17373 before i realized i was > using a different version of jQuery. > > So my question is: does Django want its JS (which already depends on > jQuery) to be more jQuery-ish ? the fixes are both forward and > backward compatible.
Hi James, As a long term goal -- yes, admin Javascript that makes better use of jQuery is certainly a goal we should be aiming for. Django's admin should also cohabitate with other jQueries (although there's been some changes over the last few months about how exactly this is achieved). If this sort of port is an area where you're interested in contributing to Django, I'd suggest dropping into #django-dev on IRC and seeing if you can find someone in the core who can spare the time to help shepherd your work into trunk . Porting the whole of admin's Javascript is obviously a big task, and I wouldn't want you to spend a month doing a lot of good work, only to have the patch go stale due to a lack of attention. > If so, should i create another ticket to attach my patches and close #17373 ? > > Sorry if I'm asking too much I'm really a newbie at contributing to > Django I don't want to learn to do things wrong Not at all -- so far you've done exactly the right thing; you've submitted a small patch for a minor cleanup issue, and you've asked for clarification about a larger issue. I hope we can shake someone out of the woodwork to match your enthusiasm :-) > PS: i also did super minor fixes to the templates to support > Twitter-bootstrap, the result is really nice. If you want I can try to > contribute that, too. This sounds like a much bigger topic, and one that I'm not really in a position to comment on -- you'd need to engage someone on the design side. Idan Gazit (idan on IRC) Django's design lead would be your best bet. Yours, Russ Magee %-) -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
