On Jan 31, 1:55 am, Jacob Kaplan-Moss <ja...@jacobian.org> wrote: > Anssi Kääriäinen wrote: > > I am commonly facing this problem: I review a ticket in Trac. I review > > the patch and make minor changes to the patch. Now, am I allowed to > > check the patch as ready for checkin? My view is that yes, as long as > > the changes are really minor (like comment cleanup). > > I agree: if it's a simple change like that, go ahead and mark it RfC yourself. > > > If I do larger changes, it seems pretty clear I am not allowed to set > > RFC. In that case, is the original submitter allowed to review my > > patch (which he is now a co-author) and set it RFC? My view of this is > > that yes, that is allowed. Reason is that it is enough that two people > > agree on the approach, even if both have worked on the patch. Is my > > view correct here? > > I think that's OK: like you said, the point of the someone-else-reviews is to > get two pairs of eyes. However, you may want to note that there's a possible > echo chamber here so that the committer knows to double check. > > > And now for something completely different: what is the current view > > of PEP-8 regarding line lengths? It seems lines longer than 80 > > characters have been checked in somewhat regularly. How long lines are > > OK, then? > > Oh man, can we please not have an argument about line length? This is one of > those holy wars that'll never end. Aim to follow PEP8 unless it looks wrong, > and if it looks wrong then make it longer.
Thanks for your reply. I agree that line lengths can lead to pointless threads. I was just wondering if the current view is that PEP8 line lengths is in effect. I think the answer you gave is clear enough: yes, unless for some reason no :) - Anssi -- You received this message because you are subscribed to the Google Groups "Django developers" group. To post to this group, send email to django-developers@googlegroups.com. To unsubscribe from this group, send email to django-developers+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/django-developers?hl=en.
