On 11 April 2012 13:37, Vinay Sajip <vinay_sa...@yahoo.co.uk> wrote:
> The errors seem to be related to Aymeric's change in r17894. If I
> change
>
>    def _reset_dicts(self, value=None):
>        builtins = {'True': True, 'False': False, 'None': None}
>        if value:
>            builtins.update(value)
>        self.dicts = [builtins]
>
> to the seemingly equivalent
>
>    def _reset_dicts(self, value=None):
>        value = copy(value or {})
>        value.update({'True': True, 'False': False, 'None': None})
>        self.dicts = [value]
>
> then the errors no longer occur.

I think this is even more correct, as the previous function allowed
for overriding "True" to something else. Although, that might break
somebody's template :)

As for the error, it's quite a puzzle. If update() tries to iterate
thru value, it means it's a non-empty sequence that's not a subclass
of dict, right? Did you manage to track what type of value it is?
There must be a bug somewhere else too.

-- 
Łukasz Rekucki

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to