On 25 elo, 19:10, Dan LaMotte <lamott...@gmail.com> wrote:
> First time contributing to Django, but I've used it for a few years now.
>  I'd like to enhance to the dev runserver to persist a socket through
> autoreloads.  I've submitted a ticket and a pull request on Github is
> linked in the ticket.
>
> If someone wouldn't mind reviewing the code and giving me some feedback,
> I'd like to help in any way I can to get this into Django.
>
> With this change, the default behavior of runserver is changed, but the
> user is allowed to opt-out passing "--nopersistsocket" to runserver.

I added some comments to the ticket. In short: yes to the idea, but
with some concerns about how to implement this safely on all supported
platforms, or adding new annoying reload problems.

BTW there is no need to post to django-developers immediately after
creating a ticket. If it seems the ticket didn't get any attention
(give at least a couple of days for the devs to react), or you have
reason to believe the ticket is Really Important (a release blocker
just before release), then post here.

Of course, first time participants to django-developers are always
welcome :)

Thanks for working on this, this should be a nice feature addition to
runserver assuming the issues mentioned in the ticket can be solved.

 - Anssi

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to