Hi Dan,

On 09/27/2012 04:47 PM, Dan Loewenherz wrote:
> Just updated the ticket.
> 
> As I commented, the heuristic for checking if a file has been modified
> lies in line 282 of collectstatic.py:
> 
> *if not prefixed_path in self.copied_files:*
> *
> return self.log("Skipping '%s' (already copied earlier)" % path)
> 
> *
> https://github.com/django/django/blob/master/django/contrib/staticfiles/management/commands/collectstatic.py#L282
> 
> This seems off, since a path may stay the same but a file's contents may
> change.

That's not checking whether the file has been modified, that's checking
whether the same source file was previously copied in the same
collectstatic run (due to overlapping/duplicate file sources of some kind).

The check for modification date is up on line 234 in the delete_file
method, which is called by both link_file and copy_file.

Carl

-- 
You received this message because you are subscribed to the Google Groups 
"Django developers" group.
To post to this group, send email to django-developers@googlegroups.com.
To unsubscribe from this group, send email to 
django-developers+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-developers?hl=en.

Reply via email to