Thanks, I added the tests and updated the patch file. There was another file that had to be modified in order to fix the bug.
I think it is ready for review. On Sunday, February 3, 2013 3:00:26 PM UTC-8, charettes wrote: > > It looks like the appropriate module to add the test. > > The next step is to upload you patch with the test to > #18150<https://code.djangoproject.com/ticket/18150>to get it reviewed. > > Simon > > Le dimanche 3 février 2013 17:26:29 UTC-5, Steven Vargas a écrit : >> >> Hi, back again. I wrote a test for 18150, I put the test method in >> tests>regressiontests>file_uploads>tests.py, is this correct? The test >> fails with unchanged django package and passes with the patch I submitted. >> >> >> On Thursday, January 31, 2013 6:25:21 PM UTC-8, Steven Vargas wrote: >>> >>> Hi, I'm a student and this is my first contribution to an open source >>> project so I am trying to learn along the way. >>> >>> Anyways, I submitted a patch for >>> #18150<https://code.djangoproject.com/ticket/18150>and I was looking for >>> input on where to go from here. On the IRC channel it >>> was suggested that I upload tests for the patch. Do I have to build an >>> django app that utilizes the methods/classes I changed? I was thinking I >>> could use unit testing as it seems to make more sense but I'm not exactly >>> sure how I would run the unit tests, I have some experience with unit >>> testing on simple java applications but nothing like Django, I'm wondering >>> where to go from here. >>> >>> Thanks! >>> >> -- You received this message because you are subscribed to the Google Groups "Django developers" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at http://groups.google.com/group/django-developers?hl=en. For more options, visit https://groups.google.com/groups/opt_out.
